Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to configure multiple tokendings instances #172

Merged
merged 8 commits into from
Aug 25, 2023

Conversation

tommytroen
Copy link
Contributor

  • existing config with TOKENDINGS_URL will be set as default if not new config flag TOKENDINGS_INSTANCES is set
  • refactor and simplify where necessary
  • move token handling into registration.go
  • add more tests

Haven't tested in cluster yet so will need to do that before merging.

Copy link
Contributor

@tronghn tronghn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm! 🎉

controllers/jwker_controller.go Outdated Show resolved Hide resolved
controllers/jwker_controller.go Outdated Show resolved Hide resolved
@tommytroen tommytroen merged commit 9048161 into master Aug 25, 2023
3 checks passed
@tommytroen tommytroen deleted the secondary_urls branch August 25, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants